fix for swarmpit issue #262 - #12
Closed
cherbst wants to merge 1 commit into
Closed
Conversation
Member
|
sorry this sat for ten months, @cherbst — you were right and it should have gone in then. #17 landed the equivalent fix before i noticed this pr, which is what made it conflict. the one thing yours had that #17 didn't — logging the nil case instead of returning silently — is now on master as 4c18c87 with you as author (#18). so your diff is in, just via a longer route than it should have taken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes swarmpit/swarmpit#262